tests: added test for Body() methods of requests using golden files #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
bigbes/TNTP-3334-iproto-is-sync-support
to
master
July 3, 2025 10:11
bigbes
force-pushed
the
bigbes/TNTP-3334-iproto-body-tests
branch
2 times, most recently
from
5977e48 to
8897eb5
Compare
bigbes
force-pushed
the
bigbes/TNTP-3334-iproto-body-tests
branch
2 times, most recently
from
55de81c to
fe36442
Compare
dmyger
reviewed
Jul 8, 2025
| // ``` | ||
| // Use it to debug the test. | ||
| // | ||
| // If you want to update the golden file, run delete old file and rerun the test. |
There was a problem hiding this comment.
It's up to you, but I think it would be more reasonable to explicitly create data files with the update-testdata flag or something similar.
Otherwise, the absence of a control file will result in the test passing successfully.
As for an example, you could check: https://github.com/tarantool/tt/blob/master/cli/tcm/log_test.go#L23
There was a problem hiding this comment.
I agree. Ideally we need to separate generation of data from tests and generate it with go generate. But a flag a good idea too.
oleg-jukovec
requested changes
Jul 8, 2025
bigbes
force-pushed
the
bigbes/TNTP-3334-iproto-body-tests
branch
from
fe36442 to
ca0c7f6
Compare
dmyger
reviewed
Jul 9, 2025
bigbes
force-pushed
the
bigbes/TNTP-3334-iproto-body-tests
branch
from
ca0c7f6 to
babd1e3
Compare
oleg-jukovec
approved these changes
Jul 9, 2025
dmyger
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the test data files for various request types.